leehaut opened a new pull request, #8379: URL: https://github.com/apache/hop/pull/8379
Fix https://github.com/apache/hop/issues/8328 ## Summary - Persist IMAP Retrieve / action type / after-get / received-date condition on the Get mails (POP3/IMAP) action using `@HopMetadataProperty` and `IIntCodeConverter`s, so values such as "Get unread messages" survive save/reopen. - Load Hop 2.13 string codes (`imaplistunread`, `ignore`, `nothing`, `get`) and Hop 2.19 integer indexes without `NumberFormatException: For input string: "ignore"`. - Cover the getpop package with serialization, load/save, metadata converter, and MailConnection tests; update deserialize/mail integration workflows and the Get mails user-manual page. ## Test plan - [x] `./mvnw -pl plugins/misc/mail -am test -Dtest=ActionGetPOPSerializationTest,ActionGetPOPTest,MailConnectionMetaTest,WorkflowActionGetPOPLoadSaveTest,WorkflowEntryGetPOPTest,MailConnectionTest,MailConnectionFilterTest` - [x] Open a workflow, set Get mails protocol to IMAP and Retrieve to **Get unread messages**, save, close the tab, reopen: the setting stays unread. - [x] Open a Hop 2.13 workflow with `<conditionreceiveddate>ignore</conditionreceiveddate>` and `<valueimaplist>imaplistunread</valueimaplist>`: it loads, and Retrieve is unread. - [x] Change Retrieve to another IMAP option, save and reopen: the new value is kept. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
