mattcasters commented on code in PR #8407: URL: https://github.com/apache/hop/pull/8407#discussion_r4020341544
########## .gitignore: ########## @@ -13,6 +13,8 @@ pom.xml.releaseBackup bin *.class *.jar +# Tiny Plexus descriptor so Debian/Ubuntu Maven can find compilerId=eclipse. +!.mvn/plexus-eclipse-hint.jar Review Comment: Intended, not leftover git ceremony — though it *is* a git hoop in the sense that `*.jar` would otherwise silently drop the file (same trap as the `subdir4.jar` note further down in this file). Why the jar is in git at all: Maven checks `systemPath` when it parses the POM, *before* `validate` can run the Groovy that rebuilds `.mvn/plexus-eclipse-hint.jar` from the XML. On a fresh clone without the committed ~1KB jar you get: ``` [WARNING] 'build.plugins.plugin[...maven-compiler-plugin].dependencies.dependency.systemPath' for org.apache.hop:plexus-eclipse-hint:jar refers to a non-existing file .../plexus-eclipse-hint.jar ``` Then Groovy writes the jar and the compile still works. Committing it just means Debian/Ubuntu Maven has a file to point at from the first invocation. The Groovy path is still there as a fallback (XML newer than the jar, or someone deleted it). If you'd rather not keep a binary in the tree we can drop both the committed jar and this `!.mvn/plexus-eclipse-hint.jar` exception and live with the one-shot warning on a clean checkout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
