fskorgen opened a new pull request, #8424: URL: https://github.com/apache/hop/pull/8424
Fixes #8357. `DatabaseMetaEditor.changeConnectionType()` replaced the `IDatabase` instance with one from `metaMap` — a cache pre-filled with an *empty* instance of every database plugin. That threw away the hostname, database name, username and password `setDatabaseType()` had just carried over. **Commit 1** keeps the cached instance for its type-specific settings and copies the entered connection details onto it. A port that is filled in comes along; an empty one falls back to the new type's default rather than to a cached value. **Commit 2** adds a *Default port* button next to the port field, shown only for types that declare a default port. Once the port survives a type change, this is how you ask for the new type's default. Happy to drop this commit if you'd rather take the defect fix alone. Tested manually in Hop GUI, switching between MySQL, MariaDB, PostgreSQL and Infobright. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
