mattcasters opened a new pull request, #8427: URL: https://github.com/apache/hop/pull/8427
Fixes #8426. #8407 made `compilerId=eclipse` work on Debian/Ubuntu `apt` Maven by committing a 1 KB Plexus descriptor jar. #8413 correctly removed that jar (ASF source releases cannot contain binaries) and left Groovy + `systemPath`, which warns on every module, is Maven 4-hostile, and starts Groovy on ~300 modules. This keeps the XML descriptor in git and generates the jar at build time: - `tools/ecj-helper` javac's a small helper (not a reactor Maven plugin — that cannot serve `mvn -pl core` on a clean `.m2`) - `exec:java` writes `.mvn/plexus-eclipse-hint.jar` and attaches the Lombok ECJ agent once per Maven JVM - `install-file` publishes it as `org.apache.hop:plexus-eclipse-hint:1.0` so the compiler plugin depends on a normal GAV, not `systemPath` Verified with **Ubuntu distro Maven 3.8.7** (`Maven home: /usr/share/maven`, `libsisu-inject-java` 0.3.4), not `./mvnw`: ``` Apache Maven 3.8.7 Maven home: /usr/share/maven Java version: 21.0.12, vendor: Ubuntu ``` - `mvn -pl core clean compile` → `Compiling with eclipse [debug release 21]` - `cd core && mvn compile` - `cd plugins/transforms/abort && mvn compile` - `./mvnw -pl core compile` still works The 7 min → 1 min ECJ figure from #8325 was not observed on Ubuntu 24.04; inherited Groovy was one reason. This drops Groovy from the parent build. #8425 (unused `os-maven-plugin` / Maven 4) is independent and can merge on its own. ------------------------ - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
