bamaer opened a new pull request, #8535:
URL: https://github.com/apache/hop/pull/8535
…r had
Both tests were merged red. The integration suite does not run in PR CI, so
nothing compared what they assert to what the code does.
0043-database-value-validation expects DBV007 and DBV008. On PostgreSQL a
uuid column is read as ValueMetaUuid and a jsonb column as ValueMetaJson, so a
value that is neither fails to convert to the target type and returns before
the check that knows what is wrong with it runs. Both codes were unreachable on
every database that has those types, and the finding carried the driver's or
parser's wording instead. The conversion failure now asks those checks first.
The validator's own tests could not catch this: they set a string target value
meta, which is the one case the real path never takes.
0001-lint-check-db-connections greps the report for
CONNECTION_DOES_NOT_EXIST. Hop's own verify remarks are reported under the rule
that covers them, HOP-CHECK in the core pack, so the error code never reaches
the JSON. The test now reads the checker's messages, and finds the hop CLI
through ${user.dir} rather than HOP_LOCATION, so it also runs from Hop GUI.
The classifier that decides this reached the command line but not the
editor: a project could switch HOP-CHECK off and watch its build go quiet while
every badge stayed on the canvas, and a suppression written from the canvas
named a rule id the command line never reported. Every path that reports a
native remark now goes through one entry point, suppression lookups included.
The classifier stays off the policy findings: the blanket rule names no plugin
and no message, so it matches every check result put in front of it, and
classifying the merged list would rename every lint finding to HOP-CHECK.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
