mattcasters opened a new pull request, #8573:
URL: https://github.com/apache/hop/pull/8573

   ## What
   
   The canvas no longer paints the finished check as soon as one copy of a 
transform is done. The check is drawn only when every copy is finished. While 
copies are still working, the same corner shows how many copies have already 
finished.
   
   Hovering the transform icon reports `Copies finished: 2 of 4` when there is 
more than one copy. A single copy is unchanged: no badge while it runs, the 
check when it finishes. A stopped copy does not count as finished, and the 
check is not painted on top of the red error icon.
   
   ## Why
   
   Fixes #8501.
   
   A transform with several copies looked finished after the first copy 
disposed, even though the other copies were still working. The pipeline itself 
was not finished early: the local engine waits until every copy has reported 
done. The metrics grid already showed one row per copy.
   
   ## Docs
   
   Specify copies explains the badge, with a screenshot of a five-copy run 
where three copies have finished. The run, preview, and debug page points there 
instead of saying every successful transform gets a check.
   
   ## Test
   
   `TransformCopyCompletionTest` and `PipelineCanvasSvgRendererTest`.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to