bamaer commented on PR #8610:
URL: https://github.com/apache/hop/pull/8610#issuecomment-5836394139
**Blocker — `pipeline != null` / `workflow != null` != "a run is active"**
`HopGuiPipelineGraph.java:1022`, `HopGuiWorkflowGraph.java:846`
The field is only cleared when a run *fails to start*, so it stays non-null
after a run finishes. The documented fallback ("with no run active, Alt-click
still opens error handling") holds only until the first run. Kafka Consumer
Input — the one transform supporting both drill-down and error handling — loses
its Alt-click error handling for the rest of the tab's life. Fix: pass the
existing null-safe `isRunning()` instead.
**Should fix — `'x'` is eaten by MessageFormat**
`messages_en_US.properties:19` + pt_BR. `BaseMessages` always runs
`MessageFormat.format`, so the tooltip renders `hit key x`. Use `''x''`.
**Should fix — `altClickOpensExecution` tests the wrong half**
`DrillDownGuiPlugin.java:276`. A public static `a && b` whose test can't
catch the call-site bug above. Inline it, or have it take the graph so the
run-active check is inside.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
