mattcasters opened a new pull request, #8635: URL: https://github.com/apache/hop/pull/8635
Switching the linter off left the Explorer mark on a file that already had findings, and opening or editing a file still linted it. The canvas badges already followed the option. The Explorer paints a file when the tree item is created, so a later redraw never cleared the color. SQL, Shell and Set Variables also checked the source the action was not using: - SQL always looked up a property named `SQL`, so a statement read from a file was reported as blank. - Shell always required a filename, including when Insert script runs the text on the Script tab. - Set Variables looked up `variableName`, which is not a field on the action, so a properties file failed with "Unable to validate." A file or a typed script is enough for SQL and Shell. A properties file or a variable list is enough for Set Variables. The check fails only when neither source is set. fixes #8521 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
