leehaut opened a new pull request, #8651: URL: https://github.com/apache/hop/pull/8651
Fix https://github.com/apache/hop/issues/8650 Adding a project from existing sources failed on OK when the parent was the standard `default` project: Project 'hop_demo' cannot reference 'default' as parent project because we are going to create a circular reference! There is no cycle. #8583 compares the parent's parent with both the new name and the original name, so a rename can still see a cycle while child configs still store the old name. A new project has an empty original name, and `default` stores `"parentProjectName": ""`. `"".equalsIgnoreCase("")` was treated as a cycle. Skip that comparison when either name is empty. An empty `parentProjectName` means "no parent". A real two-level cycle is still rejected, including a rename where the parent's parent is still the old project name. ## Test plan - [x] Add a project from existing sources with parent `default` (`parentProjectName` is `""`). OK no longer reports a circular reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
