mattcasters opened a new pull request, #8683: URL: https://github.com/apache/hop/pull/8683
Opening an execution record failed when Jackson refused the sampled-row field `rowsBinaryGzipBase64Encoded`. On Hop 2.8 the default maximum string length was 5,000,000 characters, so a value of 5,046,272 characters never deserialized and the record opened with no data. Current Jackson still stops at 20,000,000 characters, which rejects the same class of payload. `HopJson` now builds its factory with a 50,000,000-character read limit. File, database, remote, and Neo4j execution-information locations already read through `HopJson`. The caching file, Elasticsearch, and OpenSearch readers were still using a default `ObjectMapper`, so those now use the same factory. Nesting depth and name length stay at Jackson's defaults. The sampled-value limits from #8617 and the 2,000,000-character cap on cached logging text are unchanged. `./mvnw -pl core,engine -am test -Dtest=HopJsonTest,CachingFileExecutionInfoLocationTest,ExecutionDataTest -Dsurefire.failIfNoSpecifiedTests=false` passed (HopJsonTest 4, CachingFileExecutionInfoLocationTest 9, ExecutionDataTest 3). `./mvnw -pl plugins/tech/elastic,plugins/tech/opensearch test -Dtest=ElasticExecutionInfoLocationProjectIdTest,OpenSearchExecutionInfoLocationProjectIdTest -Dsurefire.failIfNoSpecifiedTests=false` passed (5 and 4). A full `mvn clean install` was not run, and Hop GUI was not opened. fixes #3745 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
