mattcasters opened a new pull request, #8686:
URL: https://github.com/apache/hop/pull/8686

   Importing a Pentaho Kafka Consumer step left the transform type as 
`KafkaConsumerInput`. Hop only rewrote the unused id 
`KettleKafkaConsumerInput`, so the pipeline kept a type that is not a Hop 
transform. Opening it failed with `Missing transform plugin`.
   
   Pentaho's step id is `KafkaConsumerInput`. The Kettle importer now maps that 
id to Hop's `KafkaConsumer` transform, and still maps the older 
`KettleKafkaConsumerInput` id. The existing renames of `transformationPath` to 
`pipelinePath` and `SUB_STEP` to `subTransform` are unchanged, so the 
sub-pipeline path, return transform, topics, consumer group, batch settings, 
bootstrap servers, output fields, and advanced options stay in the XML shape 
Hop already loads.
   
   `./mvnw -pl plugins/misc/import -am test 
-Dtest=KettleImportKafkaConsumerTest -Dsurefire.failIfNoSpecifiedTests=false` 
passed (3 tests, 0 failures). A full `mvn clean install apache-rat:check` was 
not run, and Hop GUI was not started.
   
   fixes #4106
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to