mattcasters opened a new pull request, #8689: URL: https://github.com/apache/hop/pull/8689
hop-run always replaced the file given by `--logfile` (`-lf`). A log that already existed, for example one file per day, was wiped at the start of the next run. Kitchen keeps earlier output; hop-run did not. `--logfile` still replaces an existing file, so scheduled jobs that expect a fresh log do not start filling the disk. `--logfile-append` (`-lfa`) writes after the content that is already there. The flag does nothing when `--logfile` is not set. `HopRunLogFileOptionTest` covers the default replace, append, that `-lfa` is not parsed as a log level, and that the help text documents the option. `./mvnw -pl engine -am test -Dtest=HopRunLogFileOptionTest -Dsurefire.failIfNoSpecifiedTests=false` passed. A full reactor build and a live hop-run of a workflow were not run. fixes #4296 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
