mattcasters opened a new pull request, #8692: URL: https://github.com/apache/hop/pull/8692
The Kettle import summary counted every source job, transformation, and other file as imported. With "Skip existing target files" selected, files that were left untouched were still included in those totals, so a re-import looked as if it had written them again. Skipped targets are now taken out of the imported counts. The Import summary dialog (and the `hop-import` report, which uses the same text) shows a line such as "2 jobs, 35 skipped", and the same for transformations and other files. A kind that was only skipped is still listed, with a written count of zero. When nothing is skipped the wording is unchanged. `KettleImportSkipReportTest` covers a re-import that skips an existing workflow and text file, an overwrite when skipping is off, and a summary that omits kinds that were neither imported nor skipped. Run with `tools/with-isolated-display.sh ./mvnw -pl plugins/misc/import -am test -Dtest=KettleImportSkipReportTest -Dsurefire.failIfNoSpecifiedTests=false` (3 tests, all passed). A full `mvn clean install` was not run. fixes #4500 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
