mattcasters opened a new pull request, #8695: URL: https://github.com/apache/hop/pull/8695
Script and Java editors (User Defined Java Class, JavaScript/Script, Java Filter, formula, and the other StyledText editors) already kept an undo stack, but Ctrl+Z was not consumed. The same chord then undid the pipeline or workflow and moved focus back to the graph, so undo inside the editor did not stick. Redo was only Ctrl+Shift+Z. Ctrl+Y did nothing. Ctrl+F already opens find. Ctrl+Z now undoes and Ctrl+Y redoes in those editors, and both chords are consumed so the graph shortcut does not run. Ctrl+Shift+Z still redoes. Applying undo or redo no longer records itself as a new edit, and a later edit clears redo. The editor context menu shows Ctrl+Y. Ctrl+S was left unchanged. The request marks it as optional, and it is not specified whether that should accept the dialog or save the pipeline. Hop Web script tabs still use a plain text control with no undo stack, so this does not add history there. Tests: `./mvnw -pl ui -am test -Dtest=HopGuiKeyHandlerTest -Dsurefire.failIfNoSpecifiedTests=false` (15 tests, passed) and `tools/with-isolated-display.sh ./mvnw -pl rcp -am test -Dtest=StyledTextVarHistoryShortcutTest -Dsurefire.failIfNoSpecifiedTests=false` (passed). A full reactor build was not run. fixes #4940 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
