bamaer commented on PR #8690:
URL: https://github.com/apache/hop/pull/8690#issuecomment-5928991621
**Blockers**
- **"Right pad fields" no longer pads in a new transform.** `doNotPadFields`
defaults to `true` for new transforms (`TextFileOutputMeta.java:202`) and
overrides "Right pad fields" in both padding paths (`TextFileOutput.java:591`,
`TextFileOutputMeta.java:475`). A user who creates a Text File Output and ticks
"Right pad fields" for a fixed-width file gets unpadded output, which is the
same kind of checkbox-that-does-nothing problem as #4303. On `main` that case
pads.
Suggested fix: pad when `isPadded() || !isDoNotPadFields()` in both
places, and disable "Do not right-pad fields" in the dialog while "Right pad
fields" is ticked (`TextFileOutputDialog.java:904`). Existing transforms keep
padding as today, new transforms don't pad by default, and ticking "Right pad
fields" always pads. Please add a test for the case where both boxes are
ticked, and update the tooltip and docs to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
