bamaer commented on PR #8684:
URL: https://github.com/apache/hop/pull/8684#issuecomment-5932266486
**Blockers**
- **Get Fields proposes `Date` for a Hop Date, which drops the time of
day.** `ParquetFieldType.forValueMeta` maps `TYPE_DATE` to `Date`, the Parquet
DATE type that stores days only (`ParquetFieldType.java:115`). Until now the
writer stored a Hop Date as `TIMESTAMP(MILLIS)` (`ParquetOutput.avroType`).
Database timestamp columns usually arrive as Hop Date, because "supports
timestamp data type" is off by default on connections. So Table Input → Parquet
Output → Get Fields now writes `2024-03-05 14:22:10` as `2024-03-05`, without a
warning.
Suggested fix: propose `TimestampMillis` for `TYPE_DATE`, so Get Fields
matches what the writer did before. Users who want a DATE column (for example
for BigQuery) can still select `Date`. Update
`getFieldsProposesDateForADateAndTheDefaultForTheOthers`
(`ParquetLogicalTypeTest.java:221`) and the sentence about Get Fields in
`parquet-file-output.adoc:189`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
