nadment opened a new issue, #8816:
URL: https://github.com/apache/hop/issues/8816

   ### Apache Hop version?
   
   2.20.0-SNAPSHOT
   
   ### Java version?
   
   21
   
   ### Operating system
   
   Windows
   
   ### What happened?
   
   The About dialog (Help > About) takes a noticeable time to open in Hop Gui 
on Windows.
   
   ### Cause
   
   In `AboutDialog.open()` the "Advanced" section is a multi-line `Text` 
created with `SWT.WRAP`, and it is filled with 
`wProperties.setText(getProperties())` right after creation, while the control 
still has no size.
   
   The content includes `java.class.path`, which is one very long line without 
any whitespace (tens of thousands of characters when Hop is started from an 
IDE, still long with a regular install). On Windows the native Edit control 
recomputes the word wrapping of the whole text every time its width changes, 
and that is slow on such a line.
   
   After the text is set, the dialog is sized and laid out several times before 
it is shown:
   
   ```java
   shell.setSize(width, (int) (600 * zoom));
   shell.layout(true, true);
   collapsedHeight = computeCollapsedHeight(margin);
   shell.setSize(width, collapsedHeight);
   ```
   
   Each of these re-wraps the text, although the "Advanced" section is 
collapsed when the dialog opens.
   
   ### Verification
   
   Moving `wProperties.setText(getProperties())` after the `setSize` / `layout` 
calls (just before `shell.open()`) makes the dialog open instantly.
   
   ### Proposed fix
   
   - Set the properties text after the dialog has been sized (or only when the 
"Advanced" section is expanded for the first time).
   
   ### Steps to reproduce
   
   1. Start Hop Gui on Windows (most visible when started from an IDE, where 
the classpath is very long).
   2. Open Help > About.
   3. The dialog appears after a visible delay.
   
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Hop Gui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to