mattcasters commented on PR #8819: URL: https://github.com/apache/hop/pull/8819#issuecomment-6088704803
Thanks @kotwal-itpro for staying with this. `23af45a9` addresses the last review: - The commit listener is inserted in front of Hop's execution-finished listener, so the snapshot is committed while the pipeline still reports Running. `statusIsNotFinishedBeforeTheSnapshotExists` only observes Finished once `v1.metadata.json` is in place, and a failed commit is still counted before waiters return. - Overwrite always calls `validateNoConflictingData()`, including when the table had no snapshot at the start. `overwriteOfAnEmptyTableDoesntRemoveAConcurrentFirstAppend` keeps the other writer's first snapshot. - Local publish stays on the hard link (`localPublishUsesAHardLink` checks the link count), and where hard links are not supported it uses `CREATE_NEW`. Other link errors fail the commit, and a partial version file is removed. - The version walk recognizes the legacy `v<N>.metadata.json.gz` name, in the hint walk and in `metadataVersion`. Nothing further from me on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
