bamaer commented on PR #8822: URL: https://github.com/apache/hop/pull/8822#issuecomment-6095208092
@mattcasters @hansva I went through your five remarks against 4ce5fab9f5. All look addressed, each with a test: - total timeout below the warning: now caps both, `aTotalTimeoutBelowTheWarningEndsAndReportsTheReadInTime` - overlapping `write()`/`close()`: calls are counted, `overlappingCallsStayWatchedUntilTheLastOneIsDone` - `LinkageError` on the key file: key-file wording kept, `aLinkageErrorReadingTheKeyFileBlamesTheKeyFile` - `begin()`/`end()` in `finally`, no false "resumed": `anErrorFromTheClientStillEndsTheTransfer`, `aStalledReadThatFailsIsNotReportedAsResumed` - zero timeout: now means no timeout, `aZeroTimeoutLeavesOnlyTheTotalTimeout` Code reviewed, not run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
