bamaer commented on PR #8859:
URL: https://github.com/apache/hop/pull/8859#issuecomment-6108635179
Thanks @kotwal-itpro, nice to see the series completed, and the new pages
read well.
One thing worth picking up before merge:
**Should fix**
- **A few places still use the old names.** The transform and catalog pages
and the message bundles are renamed, but the navigation, the transform index
and some cross-links still say "Spark lake table input/output" and "Spark
Catalog":
- `docs/hop-user-manual/modules/ROOT/nav.adoc:313`, `:316`, `:568`
- `docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms.adoc:232`,
`:235` (that list is alphabetical, so these would move under L)
- `metadata-types/index.adoc:74` still describes it as "Spark SQL catalog
configuration … on the native Spark engine"
- link labels in `spark-catalog.adoc:152-153`, `lakehouse.adoc`,
`getting-started-with-native-spark.adoc`, `spark-file-input.adoc`,
`spark-file-output.adoc`, `databricks.adoc`, `databricks-connection.adoc`,
`native-spark-pipeline-engine.adoc` and `paths-and-filesystems.adoc`
Suggested fix: rename the link labels to "Lake table input", "Lake table
output" and "Lakehouse catalog", and re-sort the two entries in
`transforms.adoc` and `nav.adoc`.
I reviewed the code and checked the doc claims against the lakehouse plugin
code. I didn't run the integration test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
