bamaer commented on PR #8968: URL: https://github.com/apache/hop/pull/8968#issuecomment-6215602503
LGTM, thanks @hansva. Built the PR locally and ran the affected tests (`ConstTest`, `ValueDataUtilTest`, the `RowMeta*` tests including the concurrency ones, and all Concat Fields, Fuzzy Match and String Operations tests): all green. I read each change against what it replaces and didn't find any change in results. String Operations now resolves variables in pad char and pad length, which the dialog already allowed, so that's a nice fix on top. I didn't benchmark the gains. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
