bamaer commented on PR #8959: URL: https://github.com/apache/hop/pull/8959#issuecomment-6215246600
@hansva LGTM. Verified locally: - `TextFileOutputFormatInheritanceTest` fails without the fix (`expected: <dd-MM-yyyy> but was: <>`) and passes with it; the textfile module's tests all pass. - `main-0123-text-file-output-inherited-formats` passes with the PR. Against the pre-fix jar it fails on `d_input`, `d_select` and `n_input` (written as `2024/05/17 00:00:00.000` and `42`). - `main-0108-data-set-output` still passes with the dataset moved to `output/`. I also looked for other `!= null` guards in front of mask/symbol setters; this was the only one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
