mattcasters opened a new pull request, #8983: URL: https://github.com/apache/hop/pull/8983
Show rows and other data browsers can show only the rows that match selected column values. A right-click on a column header adds or removes a filter for that column. The Table views dialog lists the applied filters, offers the unique values of a column (sorted by its type, including `<null>`), and warns when a column has more than 500 distinct values. A filtered column shows a filter icon. Named views store the filters with the column layout. Filtering stays off unless the grid opts in. Show rows is the caller that turns it on. A configuration grid leaves **Add filter** and **Remove filter** disabled and does not hide rows for a saved filter, so confirming the dialog still keeps every row. Sorting, deleting, pasting, or replacing the table restores the hidden rows before the change, or drops them when the table is cleared, and keeps the original line numbers. fixes #8941 ## Test plan - [x] `TableViewColumnViewsTest` - [x] `TableViewColumnViewFilterTest` (13) with `tools/with-isolated-display.sh` - [x] Spotless applied on `ui` - [x] Checkstyle and Apache RAT on `ui`, `rcp`, and the documentation images during review. The follow-up fixes are in files that already had license headers, and Spotless was applied again after them ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
