Adalennis commented on PR #9000: URL: https://github.com/apache/hop/pull/9000#issuecomment-6247906722
Thanks @bamaer, you were right on every point. I fixed all of them, and this time ran each row instead of only reading execute(): every row of the six tables is now backed by a test with hop-run on current main (48 cases, with a local SMTP server for Mail and an SFTP server for SFTP). - Pipeline / Workflow: with Execute for every result row each run gets its own row, and the action passes on what the last run left (the rows it copied or returned, or else the last input row). Clear results files runs before every run. Workflow replaces the rows only when the child returns at least one. - Copy files: a single file copied into a folder isn't added to the result files, and a file that fails inside a folder is only logged (true, 0 errors). - Mail: false whenever an error was counted, even when the message went out; a zip error sends the mail without the zip; a result file that no longer exists is skipped without an error unless zipping. - SFTP: false when Remove files after retrieval fails (the file is downloaded and in the result files by then); Files retrieved is only set on success; with Copy previous results to args the names are matched exactly and the wildcard is ignored. - Simple evaluation: "the Variable name field is empty", and a NOTE that an invalid regular expression stops the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
