bamaer commented on PR #9002: URL: https://github.com/apache/hop/pull/9002#issuecomment-6249475771
Thanks @Adalennis, this fills the gap from #2517 nicely. I checked the page against the code and ran the hop-run cases, and found one small inaccuracy. **Worth fixing** - `variables/parameters.adoc`, "From hop-run": `-p INPUT_FILE=` doesn't fall back to step 2. The empty value replaces the variable's value, so the parameter gets its default value. With a parameter `P` (default `def`), `-s P=sys` gives `sys`, but `-p P= -s P=sys` gives `def`. Suggested wording: drop "An empty value … counts as no value" from step 1 and add after the list: "An empty value, like `-p INPUT_FILE=`, gives the parameter its default value, even when a variable with the same name exists." Code and docs reviewed; hop-run cases run on a local 2.20.0-SNAPSHOT build. Antora site not built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
