leehaut opened a new pull request, #9013: URL: https://github.com/apache/hop/pull/9013
Fix https://github.com/apache/hop/issues/9012 ## Summary - `ActionWaitForSql.check()` validated a bean property named `WaitForSQL`. That property does not exist, so F7 always reported `WaitForSQL cannot be null or blank.`, whether or not the dialog fields were filled in. - Verification now follows the dialog: `connection` is always required, `tableName` is required when Custom SQL is off, and `customSql` is required when Custom SQL is on. - Hand-written getters and setters on the action, and `getCode()` / `getDescription()` on `SuccessCondition`, are generated by Lombok. The method names used by the dialog and by serialization are unchanged. ## Test plan - [x] Blank or whitespace connection and table name report `connection` and `tableName`, and do not mention `WaitForSQL`. - [x] A set connection and table name pass when Custom SQL is off, without checking `customSql`. - [x] With Custom SQL on, a blank script reports `customSql` and does not require a table name. A filled script still requires a connection. - [x] Constructor defaults and setter/getter round trip, including the success-condition code, description, and `lookupCode`. - [x] In Hop GUI, open a workflow with Wait for SQL, set a connection and table, press F7, and confirm the ghost-property error is gone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
