Adalennis opened a new pull request, #9040:
URL: https://github.com/apache/hop/pull/9040

   Fixes #2367
   
   Rewrites the YAML Input page. Every point was checked with hop-run against 
the current code (after the JsonPath change in #7432):
   
   - How rows are formed: several documents separated by `---`; a map at the 
top level gives as many rows as the longest list, a single value is repeated, a 
shorter list leaves its field null; a list of plain values gives one row per 
element; a path to a map gives the map as text. Example with the YAML and the 
resulting rows.
   - Paths: the "Key" column is now "Path" (JsonPath), `owner.name` is read as 
`$.owner.name`, variables are resolved, what Get fields adds.
   - What happens when a path finds nothing, or a value doesn't fit the type 
(Integer, Number, Date, Boolean). Format, Decimal and Group are not used to 
read the value.
   - "Get source from a field" (input field with the YAML or a file name) vs 
"Filename fieldname" (output field with the file name).
   - Limit: total output rows over all files. Rownum also counts over all files.
   - Descriptions for Regular Expression, the Selected files columns (Required, 
Include subfolders), Add files to result filesname, Ignore empty file, Do not 
raise an error if no files, Trim type.
   - Fixed: "Source is a filename, else a directory" (it chooses between a file 
name and YAML text in the field).
   - Dependent options are indented in the tables.
   
   
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to