bamaer commented on PR #9038: URL: https://github.com/apache/hop/pull/9038#issuecomment-6292700113
Thanks @rmannibucau. Built the PR and ran the calculator tests (86/86 green); with the two field initialisers reverted, `testRestoreLegacyXmlWithoutLengthPrecisionDefaultsToMinusOne` fails with `expected: <-1> but was: <0>`, so the test covers the regression. This also gives metadata-injected calculations without a mapped length/precision the same `-1` as a blank dialog cell. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
