mattcasters commented on PR #9203: URL: https://github.com/apache/hop/pull/9203#issuecomment-6576208870
@bamaer the fix stays the same. The comment now names removeAll(), which is what cleared the editable combo. setItems does not. JSON Input now calls ComboItems.setItemsKeepingText from #9204 instead of keeping its own restore. This branch is rebased onto issue-5953-fields, so #9203 depends on #9204 and should be merged after it. The success-path test is replaced by secondFailedLookupKeepsTheFieldAndTheLoadedList. The first lookup loads "other". The lookup from getData throws. The old removeAll() cleared that list and the configured name, so the test fails without this fix. Both UI tests passed. The "shown once" sentence was already true before this change. I left the construction-time setSourceStreamField(false) call in place. It is older than this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
