mattcasters commented on PR #9262: URL: https://github.com/apache/hop/pull/9262#issuecomment-6652191622
Thanks @bamaer, good catches. All three are addressed in 4818a3d: 1. **Broken child file falling back to the parent:** a provider is now skipped only when `getSerializer()`/`exists()` throws. Once `exists()` is true, `load()` and `readVirtualPath()` throw again, so a conflicted child `dwh.json` fails instead of returning the parent's `dwh`. Added a test for that next to the unavailable-provider one. 2. **Hop Web reloading per session:** `SharedMetadata.install()` moved to `HopWeb.configure()`, next to the scope setup, so it runs once per process. 3. **Non-local folder locking out the tools:** `hop-conf --shared-metadata-folder` and the configuration perspective run `checkLocalFolder` before saving. A bad value that's already saved is logged at startup, and the tools carry on without shared metadata, so hop-conf can still clear it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
