bamaer commented on PR #9252: URL: https://github.com/apache/hop/pull/9252#issuecomment-6636006812
@hansva LGTM. Built it and ran `PgVectorUpsertTest` and `PgVectorUpsertPostgresIT` (pgvector container): all pass. With the pre-fix `PgVectorUpsert` the new IT fails with `committed halfway ==> expected: <0> but was: <20>`, so it covers the bug. The DDL inside the shared transaction is safe next to other transforms' savepoints, since `SharedConnectionLock` serialises `execStatement` as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
