bamaer commented on PR #9251: URL: https://github.com/apache/hop/pull/9251#issuecomment-6677784585
@hansva thanks, the second commit fixes the ordering. I built the PR and ran the Update tests: all pass. I also broke the fix on purpose in two ways (sending skipped rows straight to the output, and flushing on the batch size only); the new H2 tests catch both. No further remarks from my side. Tested: Update unit tests including the new H2 tests. Not tested against SQL Server or Oracle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
