bamaer commented on PR #9308: URL: https://github.com/apache/hop/pull/9308#issuecomment-6678597801
Thanks @hansva, code reviewed. Built core/engine/ui from this branch and ran `PipelineRowSamplerHelperTest` (6/6). I also ran a local stress test with one writer and two readers locking the buffer the way the painter and dialog do, over 3M rows per sample type, and saw no exceptions; Last always read back newest-first and contiguous. First/Last give the same results as before, and the per-row-set hop cache is safe since every `putRowTo` caller writes to one row set per target. LGTM. Did not run it in the GUI or reproduce the timings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
