bamaer commented on PR #9352: URL: https://github.com/apache/hop/pull/9352#issuecomment-6694371695
Thanks @hansva, LGTM. What I checked: - Built the plugin and ran its unit tests: 21 pass. - Compared `TokenTemplate` with the old `TokenReplacingReader` on 300,000 random templates: nine marker pairs, including overlapping ones (`%%`/`%%`, `aba`/`a`), plus unclosed and unknown tokens, null values and values that contain markers. Same output in every case. - Timing, 3,200-character template with 3 tokens, 20,000 rows: 4.8 s before, 40 ms after. Not run: integration test 0094. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
