bamaer commented on PR #9351:
URL: https://github.com/apache/hop/pull/9351#issuecomment-6694288728

   Thanks @hansva, looks good.
   
   Built the avro plugin and ran its tests: all pass. 
`buildsTheValueMetadataOncePerFieldAndType` fails against the current 
`AvroDecode` and passes with this change. I also compared output before and 
after on 15 target conversions (String/Integer/Number/BigNumber/Date with 
number and date formats), with field types changing between records: identical 
results.
   
   LGTM.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to