leehaut commented on PR #9237:
URL: https://github.com/apache/hop/pull/9237#issuecomment-6624737599
Thanks for the review, @bamaer — addressed as follows:
1. Wildcards are now compiled only when *Limit action to*
(`specifyWildcard`) is selected. Leftover text in the fields is ignored when
the option is off. The NOTE was updated to match.
2. Pattern validation now runs before `createDestinationFolder`, so an
invalid wildcard no longer creates the destination folder as a side effect. The
existing test asserts the folder is not created.
3. Agreed this is a behaviour change for existing workflows. I'll add the
following to the PR description for the release notes:
**Breaking / behaviour change (XML well formed):** wildcards are matched
against the file basename, not the full VFS path, consistent with Files exist,
Folder is empty and Check files locked. Patterns written against the full path
(e.g. `.*/in/.*\.xml` or `file:///.*\.xml`) will no longer match. With *Include
subfolders*, filtering by subfolder path is no longer possible either; update
wildcards to basename patterns such as `.*\.xml` or `orders\.xml`.
4. Tests updated:
- `oneFieldResultRowUsesEmptyWildcard` now uses a folder path so the
empty-wildcard “check the whole folder” path is covered
- added `basenameWildcardMatchesFileNameInSubfolder` for the *Include
subfolders* branch
Please take another look when you have a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
