bamaer commented on PR #9319: URL: https://github.com/apache/hop/pull/9319#issuecomment-6678744819
Thanks @leehaut, this fixes a lot in one go. I built the plugin and ran its tests (all pass), and tried Sign / Sign and encrypt with a passphrase-protected key on GnuPG 2.4: works, and a wrong or empty passphrase fails as expected. I did not run a full workflow through hop-run. **Blockers** - **Move source file to folder now overwrites the existing destination** (`ActionPGPEncryptFiles.java:888`, `ActionPGPDecryptFiles.java:765`). On main this option leaves the existing destination alone and moves the source to the move-to folder, the same as Move files does for this option (`ActionMoveFiles.java:793`). Workflows that use it to archive sources that were already processed would start overwriting those files on upgrade. Suggested fix: keep main's behaviour for Move source file to folder, and for Delete source file delete the source and leave the destination, as Move files does. That also avoids counting a file as written and as an error when "If moved file exists" is Fail. **Minor** - The decrypt page says a missing GPG location makes the action false. With "Success when number of errors lesser than" (default 10) it is true, as the encrypt page already says. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
