Adalennis opened a new pull request, #9277:
URL: https://github.com/apache/hop/pull/9277

   ixes #9265
   
   Adds the six `@Variable` declarations that were missing from 
`variables.adoc`. Each description was checked against the code that reads the 
variable on current main, and the behaviour of 
`HOP_IMPORT_ENVIRONMENT_VARIABLES` and `HOP_CONSOLE_COLORS` was also tested on 
Hop 2.20.0.
   
   - `HOP_BINARY_FIELDS_AVOID_HEX_PREVIEW`: applies to the preview windows 
(`PreviewRowsDialog`, `ShowRowsDialog`), the Database perspective results and 
the Parquet preview in the File Explorer, which use 
`RowPreviewSupport.formatCell`. It is only read from hop-config 
(`HopConfig.readStringVariable`), and the two preview dialogs keep it in a 
`static final`, so the page says to restart Hop GUI after changing it.
   - `HOP_IMPORT_ENVIRONMENT_VARIABLES`: tested with the flag in hop-config, as 
an exported variable and with `-D`. With N an exported variable doesn't resolve 
as `${NAME}`; with Y it does, and a variable of the same name set with `-D` or 
in hop-config keeps its value.
   - `HOP_SERVER_RETRIES` and `HOP_SERVER_RETRY_BACKOFF_INCREMENTS`: only the 
pipeline status request is retried (`RemoteHopServer.requestPipelineStatus`, 
the only caller of `execService(..., true)`). The wait follows `getDelay`: 1, 
1, 2, 3, 5... times the base value plus up to 25% random extra. The `@Variable` 
description says "send data", which the page doesn't repeat.
   - `HOP_TABLE_VIEW_EXTRA_COLUMN_MARGIN`: added to the column width in 
`TableView.optWidth`. It is read once into a `static final`, so the page says 
to restart Hop GUI.
   - `HOP_CONSOLE_COLORS`: added to the environment variables table rather than 
the global one. `ConsoleLoggingEventListener` reads it from a system property 
or the environment when logging starts, before hop-config is applied, so a 
value set in the configuration perspective has no effect (tested). Only error 
lines are colored.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to