bamaer commented on PR #9410:
URL: https://github.com/apache/hop/pull/9410#issuecomment-6771910538

   Thanks @mattcasters, nice to have Bulk API 2.0 without pulling in another 
SDK. The reversed-results matching test is a good touch.
   
   What I ran: built the PR and ran the 15 `SalesforceBulk*Test` unit tests, 
which all pass. I did not run the `integration-tests/salesforce` project or 
anything against a real org.
   
   **Blocker**
   
   Date values move by a day depending on the JVM time zone.
   
   - **Load** (`SalesforceBulkValues.formatDate`): on a Europe/Brussels JVM, a 
Hop date of 2026-03-15 goes into the CSV as `2026-03-14T23:00:00.000Z`. 
Salesforce Insert sends the same row as `2026-03-15T00:00:00Z` 
(`SalesforceTransform.normalizeValue`).
   - **Input** (`SalesforceBulkValues.parseDate`): a Date field holding 
`2026-03-15` is parsed as UTC midnight. On an America/New_York JVM that is 
2026-03-14 20:00, so it shows and is written out as 2026-03-14.
   
   Suggested fix: on load, keep the wall-clock time the way `normalizeValue` 
does. On input, parse the `yyyy-MM-dd` pattern in the local zone. With that 
change, Brussels, New York and Tokyo all give `2026-03-15T00:00:00.000Z` on 
load and `2026-03-15` on input. A test in `SalesforceBulkValuesTest` that sets 
a non-UTC default zone would keep it fixed.
   
   **Question**
   
   Has this been run against a real Salesforce org at least once, for example a 
free Developer Edition org? The ITs and WireMock tests use a stub built from 
the docs. Row matching depends on Salesforce echoing the uploaded values 
unchanged in the result files, which a stub can't confirm. A short note in the 
PR on what was run against a real org (operations and field types) would be 
enough.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to