bamaer commented on PR #9354:
URL: https://github.com/apache/hop/pull/9354#issuecomment-6797651868

   Thanks @hansva, all fixed in the new commit:
   
   - **High Priority / locking:** I dropped `LOCK IN SHARE MODE` completely, so 
High Priority only adds `HIGH_PRIORITY` again and the tooltip is accurate. With 
an autocommit `SELECT ... INTO OUTFILE`, InnoDB already exports a consistent 
snapshot, so the export gives the same rows. The only difference is that 
concurrent writers are no longer blocked while it runs.
   - **Empty connection:** now `Utils.isEmpty(connection)`, so an empty 
connection gives "No database connection is defined" again.
   - **File name in `INTO OUTFILE`:** quotes are now escaped like the other 
literals. The second export in `main-0050` now writes 
`0050-normal-priority-o'brien.txt`, so the IT covers it.
   - **SQL whitespace in the test:** the tests now only check whether 
`HIGH_PRIORITY` and `LOCK IN SHARE MODE` are present.
   - **`getResourceDependencies()`:** guarded in both actions.
   - **`ActionMysqlBulkLoad`:** an unknown connection now logs "Database 
connection [x] could not be found." The outer `catch (Exception)` already made 
it a false result with 1 error, but the log showed an NPE stack trace as the 
reason.
   - **`java.io.File`:** replaced with `HopVfs.fileExists()`. An empty file 
name counts as not existing, because otherwise it would resolve to the working 
folder.
   
   Ran the `ActionMysqlBulk*` unit tests (16 passed) and the `database` IT 
project with `run-tests-docker.sh` (54 passed, including 
`0050-mysql-bulk-file`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to