bamaer commented on PR #9361:
URL: https://github.com/apache/hop/pull/9361#issuecomment-6799104169

   Thanks @hansva, all addressed in ce78b55e7e:
   - Codepage is now an `IEnumHasCodeAndDescription` enum and the dialog stores 
the code. The code for Specific stays `Specific` so English files don't change; 
the translated labels older dialogs saved are mapped back on load and at run 
time.
   - Specific codepage must be a number, ACP, OEM or RAW, otherwise the action 
fails with 1 error before any SQL is sent.
   - `check()` reports an empty or invalid Specific codepage.
   - The IT first asserts that `not-mssql` resolves to a PostgreSQL connection; 
an unknown connection now gets its own error instead of an NPE.
   - Unit tests capture the generated SQL (FIRSTROW+LASTROW, codepage variants, 
the failing checks).
   - `fail()` helper, trailing newline fixed.
   
   mssql ITs pass on 2022 and 2025.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to