bamaer commented on PR #9389:
URL: https://github.com/apache/hop/pull/9389#issuecomment-6801032215

   Thanks @hansva, addressed in a79210d762:
   - The environment variable is now only sent over https to the provider's own 
domain (or when no base URL is set). Any other base URL, a custom OpenAI 
provider included, gets no key and the log says why. Hop variables still 
resolve for any endpoint. The ITs now check the stub never receives the 
environment key.
   - Unresolved check uses `StringUtil.containsVariableToken()`; a discarded 
key is logged, without its value.
   - One descriptor per provider; the variable name comes from the meta's 
`DEFAULT_*` value.
   - Tests: `127.0.0.1` on both sides, the stray-brace test is folded into 
`keyDefaultsNameTheProvidersVariable`, and the reflection test no longer 
depends on a field count.
   - Samples: placeholder key parameters removed from all five Language Model 
Chat samples; Hugging Face uses `${HF_ACCESS_TOKEN}`.
   - `hop-config.json` is the same file 28 other IT projects ship; I'd rather 
clean those up together in a separate PR.
   - A general mechanism for secrets from the environment: agreed, follow-up.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to