bamaer commented on PR #9454: URL: https://github.com/apache/hop/pull/9454#issuecomment-6877124837
Thanks @hansva, the integration test covers it: normal, empty and null HTML, once with one copy and once with three. I built the branch and the plugin tests pass (10/10). The last commit also removes "Use parallelism". The rows that come out are the same, but on upgrade: - a pipeline that had the option on silently runs one thread per copy; - the setting is dropped the next time the file is saved. Neither is in the "Behavior that changes" section of #9451. **Should fix** Could we keep the removal out of this PR? Two options: - keep the fixed parallel mode as it was in adcefa93d6 and remove it in a separate issue, or - keep `parallelism` as a `@Deprecated` field that is still read, and log a warning in `init()` when it is on, saying to set the number of copies instead. Add it to "Behavior that changes" as well. @mattcasters, your approval was on adcefa93d6, before this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
