gvdutra opened a new pull request, #9494: URL: https://github.com/apache/hop/pull/9494
Fixes #9423. Hop launchers pass external settings such as `HOP_PASSWORD_ENCODER_PLUGIN=AES2` to the JVM as system properties. Variable initialization was loading those properties before the defaults from `hop-config.json`, so the stored `Hop` default replaced the explicit external value. Load Hop configuration defaults first and overlay JVM properties afterward. Parent, project, environment, and injected variables are still applied later and keep their higher precedence. Tests: - Added a regression test that reproduces `AES2` being replaced by `Hop` before the fix. - Added a precedence test confirming explicit parent values still override system properties. - `./mvnw -pl core test` (2,096 tests) - `./mvnw -pl core -Dtest=VariablesTest test spotless:check` (17 tests) ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
