bamaer commented on code in PR #9493: URL: https://github.com/apache/hop/pull/9493#discussion_r4577265337
########## docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/cratedb-bulkloader.adoc: ########## @@ -85,3 +85,7 @@ At the moment, Hop only supports the `Basic` and `Bearer` authentication methods Map the current stream fields to the CrateDB table's columns. +== Samples + +The samples project has `transforms/cratedb-bulk-loader.hpl`, which loads two rows from a Data grid into the `doc.types_test` table. +Create a CrateDB connection named `cratedb` before you run it. Review Comment: With only a `cratedb` connection the sample still fails. Init stops with "No fields found in table" until `doc.types_test` exists, and once it does, the first row fails because the mapping lists `ratio` and `when_ts`, which the Data grid doesn't have. It looks like a copy of `integration-tests/cratedb/0004-copy-from-filesystem-types.hpl` without those fields. I'd leave this page out of the batch, like Column exists and DDL, until the sample is fixed. ########## docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/csvinput.adoc: ########## @@ -72,3 +72,8 @@ WARNING: For technical reasons, parallel reading of CSV files is only supported |Get Fields button|Click to return a list of fields from the target file based on the current settings (i.e. Delimiter, Enclosure, etc.). All fields identified will be added to the Fields Table. |=== + +== Samples + +The samples project has `transforms/csvinput-basic.hpl`, which reads `files/books-tiny-file.csv` and adds a row number. Review Comment: The textfile samples also have `workflows/write-read-huge-file.hwf`, which writes a 25M-row file and reads it back with `workflows/csvinput-huge-file.hpl`: CSV input with 4 copies and parallel reading. With the parallel-reading warning above, that one is worth naming here too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
