bamaer commented on code in PR #9495:
URL: https://github.com/apache/hop/pull/9495#discussion_r4582838101


##########
docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/dorisbulkloader.adoc:
##########
@@ -71,4 +71,9 @@ The Doris Bulk Loader allows you to insert data into Apache 
Doris at high speed
 |Option|Description
 |Header/value
 |Use this to add extra option to the bulk load command
-|===
\ No newline at end of file
+|===
+
+== Samples
+
+The samples project has `transforms/doris-bulk-loader.hpl`, which loads two 
rows from a Data grid into Apache Doris.
+Set the FE host, the FE HTTP port, the database, the table and the login in 
the transform before you run it.

Review Comment:
   With only these settings filled in, the first row fails with 
`ArrayIndexOutOfBoundsException: Index -1` before the transform contacts Doris. 
The sample sets no Data field (`DorisBulkLoader.java:69`), and Format is empty 
too. The transform sends one field per row as a CSV or JSON line, but the Data 
grid keeps `id` and `name` in separate fields, so no field holds a whole line 
to load. I'd leave this page out of the batch, like CrateDB in #9493, until the 
sample builds that line and sets Data field and Format.



##########
docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/excelinput.adoc:
##########
@@ -152,3 +152,6 @@ Some of these are missing.
 |Root uri field|The field name that contains only the root part of the URI.
 |===
 
+== Samples
+
+The samples project has `transforms/microsoft-excel-input.hpl`, which reads 
the `id`, `title` and `author` of two books from the `Books` sheet of 
`files/microsoft-excel-input.xlsx`.

Review Comment:
   The static samples also have `pipelines/read-transactions.hpl`, which reads 
every `file-*.xlsx` in `pipelines/input/` with a regex file mask and uses the 
sheet row number to split the header row from the data. It could get a line 
here too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to