bamaer opened a new pull request, #9544: URL: https://github.com/apache/hop/pull/9544
The XML Join dialog is reworked: - The options are grouped, with field pickers and tooltips. "Complex join" becomes "Add elements: under one node / under the node of their key". - *Load* shows the first target document as a tree beside the options. Clicking a node writes the XPath statement, and in key mode you also choose the key there. - The line under the XPath statement checks the statement against the loaded document as you type. It names the node the elements go under, or says why there's no match or the statement isn't valid. The transform runtime and the saved format are unchanged. New ITs cover every option, the error cases, a chain of joins and metadata injection (`xml/0028`–`0030`, `mdi/0062`). They pass on main and on this branch. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
