nadment opened a new pull request, #9571:
URL: https://github.com/apache/hop/pull/9571
Fixes #9534
After a refused username/password, the Git plugin could stop asking for
credentials: every later fetch, pull or push sent the same refused credentials
until Hop was restarted.
**Changes**
- `UIGit` now also recognises as an authentication failure:
- an HTTP 403 (`… not permitted on …`), which GitLab answers after a few
failed attempts, as does a server where the account has no access;
- an HTTP 401 without an authentication challenge (`… authentication not
supported`), which Gitea answers to the credentials it refuses. This only
counts when credentials were sent: without them, asking would not help.
- Refused credentials are forgotten on every authentication failure, so the
next operation asks again, even when the user cancelled the dialog or the
failure came from the automatic fetch.
- The title and labels of `EnterUsernamePasswordDialog` were hard-coded in
English: they are now translated, and the class description says what the
dialog does.
**Tests**
`UIGitTest` gets tests against a local HTTP server that answers 401, 401
without a challenge (like Gitea), or 403 to refused credentials. They fail
without the change.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [ ] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]