bamaer commented on code in PR #9558:
URL: https://github.com/apache/hop/pull/9558#discussion_r4627250986


##########
core/src/main/java/org/apache/hop/core/row/value/ValueMetaBase.java:
##########
@@ -6077,6 +6097,32 @@ public void storeMetaInJson(JSONObject jValue) throws 
HopException {
     jValue.put(CONST_LENGTH, getLength());
     jValue.put(CONST_PRECISION, getPrecision());
     jValue.put("conversionMask", getConversionMask());
+    // The rest of what the binary format (writeMeta) keeps: where the field 
comes from and how
+    // its values are written, read and compared.
+    jValue.put(JSON_ORIGIN, getOrigin());
+    jValue.put(JSON_COMMENTS, getComments());
+    jValue.put(JSON_DECIMAL_SYMBOL, getDecimalSymbol());
+    jValue.put(JSON_GROUPING_SYMBOL, getGroupingSymbol());
+    jValue.put(JSON_CURRENCY_SYMBOL, getCurrencySymbol());
+    jValue.put(JSON_ROUNDING_TYPE, getRoundingType());
+    jValue.put(JSON_TRIM_TYPE, (long) getTrimType());
+    jValue.put(JSON_DATE_FORMAT_LENIENT, isDateFormatLenient());
+    if (getDateFormatLocale() != null) {
+      jValue.put(JSON_DATE_FORMAT_LOCALE, 
getDateFormatLocale().toLanguageTag());
+    }
+    if (getDateFormatTimeZone() != null) {
+      jValue.put(JSON_DATE_FORMAT_TIME_ZONE, getDateFormatTimeZone().getID());
+    }
+    jValue.put(JSON_LENIENT_STRING_TO_NUMBER, isLenientStringToNumber());
+    jValue.put(JSON_STRING_ENCODING, getStringEncoding());
+    jValue.put(JSON_CASE_INSENSITIVE, isCaseInsensitive());
+    jValue.put(JSON_COLLATOR_DISABLED, isCollatorDisabled());
+    if (getCollatorLocale() != null) {
+      jValue.put(JSON_COLLATOR_LOCALE, getCollatorLocale().toLanguageTag());

Review Comment:
   Thanks @hansva, that resolves it. Rebuilt from 5baa12a: the cross-locale 
case now gives main's output, explicit settings still round-trip, and the new 
test fails on the previous commit as it should.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to