bamaer opened a new pull request, #9618: URL: https://github.com/apache/hop/pull/9618
Fixes #9500, parts 1, 4 and 5. Parts 2 and 3 were done in #9524. - **SARIF:** declares every enabled rule, as `--list-rules` lists them, also the ones that found nothing, and records the run in `runs[0].invocations`: `executionSuccessful`, `exitCode`, the config file and baseline (relative to the folder linted), severity, fail-on and the rule packs with their versions. Packs can declare `pack: version:`; the core pack has Hop's version. `hop lint` and the Run Linter action write the same. - **SEC-002/003:** report `privateKey` and `connectionString` by name, and, with the new `passwordFields: true` parameter they set, every text field Hop stores as a password. Rules without the parameter report what they did before. New findings on projects that have them: Event Hubs `sasKey` and `storageConnectionString`, Beam Snowflake `privateKey`, the SNS/SQS `awsKey`, FTP Delete `keyFilePass`. These are errors, so a build that fails on errors can start failing after the upgrade. The Kinesis stream name is no longer marked as a password; it is stored exactly as before. - **Option conditions and fields:** `HAS_OPTION` and `OPTION_MATCHES` on a connection's options, `url` on connections (never shown in a finding), `category` on transforms, `actionsWithoutFailurePath` on workflows. `appliesTo: [POSTGRESQL]` on a connection rule now matches PostgreSQL connections. Tests: unit tests in the lint module (512 pass) and the Beam plugin, and three new ITs in `integration-tests/lint` (main-0007 to 0009). With main's lint plugin those three fail; with this branch the whole lint project passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
